Breaking: Fix plugin addition order #1717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! I can't imagine that anyone was relying on the old behavior, but we should advertise this change for existing custom plugin authors. |
ghost
deleted the
Code-Hex
added a commit
to Code-Hex/gqlgen
that referenced
this pull request
Jan 24, 2022
This reverts commit f591c8f.
StevenACoffman
pushed a commit
that referenced
this pull request
Jan 24, 2022
StevenACoffman
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As posted in Discord, the api.AddPlugin function appends plugins to the existing array of plugins, this causes the default plugins to run after the custom plugins, overwriting the result. (the modelgen hook example in the documentation does not work)
This fix makes it prepend the new plugin. May or may not be a breaking change for some.