Improve websocket close

[maeglindeveloper]

Describe your PR and link to any relevant issues.

I have:

• Added tests covering the bug / feature (see testing)
• Updated any relevant documentation (see docs)

[coveralls]

Coverage decreased (-0.3%) to 66.009% when pulling 2a63394 on maeglindeveloper:improve-websocket-close into f4bf1f5 on 99designs:master.

[maeglindeveloper]

hey @vektah any thoughts on this :) ?

[maeglindeveloper]

Hey there, anything I can do to have it merged ? @vektah ?
Let me know

[zdraganov]

Good job!

[maeglindeveloper]

@mtibben, I saw that you merged lot of PR this month, could you please review this one ?

[jaredly]

impl looks reasonable, but I'd like to see a test

[StevenACoffman]

@maeglindeveloper if you can add a test for this, I would be happy to merge it! Thanks for your patience while this project was inactive but we're catching up now and would love to have this added in!

[StevenACoffman]

@zdraganov what do you think of this PR now that yours has been merged?

[zdraganov]

This can be closed. The other PR is covering this and more.

[StevenACoffman]

Ok, closing in favor of #1578 but anyone is welcome to open a new PR if there's something missing.