Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix null input for slice should convert to nil rather than a empty slice #1204

Closed
wants to merge 3 commits into from
Closed

Fix null input for slice should convert to nil rather than a empty slice #1204

wants to merge 3 commits into from

Conversation

NateScarlet
Copy link

Describe your PR and link to any relevant issues.

Fix #1203

I have:

  • Added tests covering the bug / feature (see testing)
  • Updated any relevant documentation (see docs)

@NateScarlet
Test for nullable input slice 99designs#1203
d3bfc92
@NateScarlet
Fix 99designs#1203 Null input for slice should convert to nil rather …
422ab49 
…than a empty slice

not change IsNilable because other tests will fail if we do
@coveralls
Copy link

coveralls commented Jun 2, 2020 •
edited
Loading

Coverage Status

Coverage remained the same at 66.069% when pulling 2a11017 on NateScarlet:issue-1203 into 40570d1 on 99designs:master.

@lwc
Copy link
Member

lwc commented Jul 10, 2020

Superseded by #1242

@lwc lwc closed this Jul 10, 2020
@lwc lwc mentioned this pull request Jul 10, 2020
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Null input for slice should convert to nil rather than a empty slice
3 participants
@NateScarlet @coveralls @lwc