federation: generate _entities / _service root queries regardless of … #1192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…entity count Generate a valid federation schema extention if no object uses @key directive. On this case the extension will be defined as follows: ```graphql union _Entity type _Service { sdl: String } extend type Query { _entities(representations: [_Any!]!): [_Entity]! _service: _Service! } ``` Signed-off-by: Alex Snast <[email protected]>
alexsn
force-pushed
the
federation/service
branch
from
097b1d4 to
947cd42
Compare
|
This seems to fix issue #1090. We this haven't been merged? |
|
This sat in review for a long time without any comments. I assumed maintainers were not interested. |
|
I think this should be reopened, there are legitimate reasons for federating servers even if no object has a @key and so this should be default behaviour |
|
I second this |
|
i got 422 Unprocessable Entity, is this will be the solution ? |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…entity count
Generate a valid federation schema extention if no object uses @key
directive.
On this case the extension will be defined as follows:
I have: