Remove source reprinting #1019
Merged
Remove source reprinting #1019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codegen/config/config.go
Outdated
| var schemaRaw []byte | ||
| schemaRaw, err = ioutil.ReadFile(filename) | ||
| if err != nil { | ||
| fmt.Fprintln(os.Stderr, "unable to open schema: "+err.Error()) |
There was a problem hiding this comment.
why not return an error like the rest of the error blocks within the function?
There was a problem hiding this comment.
Just copy paste, thanks :)
cgxxv
pushed a commit
to cgxxv/gqlgen
that referenced
this pull request
Mar 25, 2022
…ting Remove source reprinting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the
MutateSchemaplugin hook, the only schema changes we need right now are additive. This means:extend type Footo extend remote federated types, rather than@extendsWe will likely need to bring MutateSchema back at some point to handle relay Connections, but lets cross that bridge when we get to it.
@marwan-at-work
Re-up of #1015