Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

directive arg name keyword is not converted #860

Closed
lian-yue opened this issue Sep 15, 2019 · 0 comments · Fixed by #907
Closed

directive arg name keyword is not converted #860

lian-yue opened this issue Sep 15, 2019 · 0 comments · Fixed by #907
Labels
bug Something isn't working

Comments

@lian-yue
Copy link
Contributor

What happened?

gofmt failed on *** expected 'IDENT', found 'type' (and 1 more errors)

What did you expect?

Minimal graphql.schema and models to reproduce

directive @permission(
    type: String!
) on FIELD_DEFINITION | INPUT_FIELD_DEFINITION

versions

gqlgen version v0.9.4-0.20190828043904-55b2144289de

Bug location

https://github.com/99designs/gqlgen/blob/master/codegen/directive.go#L170

res += fmt.Sprintf(", %s %s", templates.ToGoPrivate(arg.Name) templates.CurrentImports.LookupType(arg.TypeReference.GO))
@vektah vektah added the bug Something isn't working label Sep 16, 2019
lian-yue added a commit to lian-yue/gqlgen that referenced this issue Oct 20, 2019
@lian-yue
Update directive.go
2a943ee 
fix 99designs#860 directive arg name keyword is not converted
@lian-yue lian-yue mentioned this issue Oct 20, 2019
Merged
vektah added a commit that referenced this issue Oct 28, 2019
@vektah
Merge pull request #907 from lian-yue/patch-1
756dcf6 
fix #860 directive arg name keyword is not converted
cgxxv pushed a commit to cgxxv/gqlgen that referenced this issue Mar 25, 2022
@lian-yue
Update directive.go
d89bb4a 
fix 99designs#860 directive arg name keyword is not converted
cgxxv pushed a commit to cgxxv/gqlgen that referenced this issue Mar 25, 2022
@vektah
Merge pull request 99designs#907 from lian-yue/patch-1
64da08c 
fix 99designs#860 directive arg name keyword is not converted
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix #860 directive arg name keyword is not converted lian-yue/gqlgen
2 participants
@vektah @lian-yue