Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bad type name conversion #577

Closed
giter opened this issue Mar 5, 2019 · 3 comments · Fixed by #591
Closed

Bad type name conversion #577

giter opened this issue Mar 5, 2019 · 3 comments · Fixed by #591
Labels
bug Something isn't working v0.8.1 Fixed in 0.8.1

Comments

@giter
Copy link

giter commented Mar 5, 2019 •
edited
Loading

Expected Behaviour

With latest release v0.8.0

input ITicket { otype: String! }

=>

type ITicket struct { Otype string json:"otype"}

Actual Behavior

input ITicket { otype: String! }

=>
type Iticket struct { Otype string json:"otype" }

Minimal graphql.schema and models to reproduce
@mathewbyrne mathewbyrne added the bug Something isn't working label Mar 6, 2019
@vektah
Copy link
Collaborator

vektah commented Mar 6, 2019

Fixed by #579

@vektah vektah closed this as completed Mar 6, 2019
@vektah vektah added the v0.8.1 Fixed in 0.8.1 label Mar 6, 2019
@vvakame vvakame reopened this Mar 7, 2019
@vvakame
Copy link
Collaborator

vvakame commented Mar 7, 2019

@vektah my change can't handling this issue... 😿
because, ITicket will split into ["ITicket"] and it doesn't have commonInitialisms prefix.

@vvakame vvakame mentioned this issue Mar 7, 2019
Merged
2 tasks
giter added a commit to giter/gqlgen that referenced this issue Mar 8, 2019
@giter
quick fix 99designs#577 if we already have a camel name
e435e72
@giter
Copy link
Author

giter commented Mar 8, 2019

I created a new PR but this may cause some commonInitialisms tests fail

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working v0.8.1 Fixed in 0.8.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix mixed case name handling in ToGo, ToGoPrivate 99designs/gqlgen
4 participants
@mathewbyrne @vvakame @giter @vektah