"reloading module info" doesn't work

[vikstrous2]

What happened?

I see "reloading module info" 3 times when we generate our config, so I did a little test to see if it actually helps with anything. It doesn't appear to. It seems to just cause unnecessary slowness.

diff --git a/internal/code/packages.go b/internal/code/packages.go
index c800d3d8..bb92c802 100644
--- a/internal/code/packages.go
+++ b/internal/code/packages.go
@@ -71,6 +71,9 @@ func (p *Packages) LoadAll(importPaths ...string) []*packages.Package {
                        fmt.Println("reloading module info")
                        pkgs, err = packages.Load(&packages.Config{Mode: mode}, missing...)
                }
+               if !p.checkModuleLoaded(pkgs) {
+                       fmt.Println("waste of time")
+               }
 
                if err != nil {
                        p.loadErrors = append(p.loadErrors, err)

What did you expect?

reloading module info
reloading module info
reloading module info

What I saw:

reloading module info
waste of time
reloading module info
waste of time
reloading module info
waste of time

Minimal graphql.schema and models to reproduce

our config is massive, sorry...

versions

• go run github.com/99designs/gqlgen version? 0.17.22
• go version? 1.19

Removing this "reloading" reduces the run time for us from 38s to 26s

[vikstrous2]

I also see that if we don't call "evict" or "reloadall" we can run gqlgen in 15s rather than 26, so saving 10s or 50% of the run time... but that's a topic for another issue.