Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Special characters in module path cause codegen errors #1136

Closed
ddevault opened this issue Apr 6, 2020 · 0 comments · Fixed by #1137
Closed

Special characters in module path cause codegen errors #1136

ddevault opened this issue Apr 6, 2020 · 0 comments · Fixed by #1137

Comments

@ddevault
Copy link
Contributor

ddevault commented Apr 6, 2020

What happened?

go mod init https://git.sr.ht/~example/foo.bar
go run github.com/99designs/gqlgen init
go build # many errors

What did you expect?

These characters are valid for use in module URLs, so gqlgen should rewrite them to something suitable for its identifiers.

  • gqlgen version? 0.11.3
  • go version? 1.14.1 linux/amd64
  • dep or go modules? go modules
ddevault added a commit to ddevault/gqlgen that referenced this issue Apr 7, 2020
@ddevault
Replace ~ with א in package names
9b823a3 
Fixes 99designs#1136
@ddevault ddevault mentioned this issue Apr 7, 2020
Merged
cgxxv pushed a commit to cgxxv/gqlgen that referenced this issue Mar 25, 2022
@ddevault
Replace ~ with א in package names
c4148d4 
Fixes 99designs#1136
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Replace ~ with א in package names ddevault/gqlgen
1 participant
@ddevault