resolve scalar types in exec

99designs · Oct 18, 2016 · fb3a6fc · fb3a6fc
1 parent 4cb8dcc
commit fb3a6fc
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 12 deletions.
diff --git a/internal/exec/exec.go b/internal/exec/exec.go
@@ -17,6 +17,14 @@ type Exec struct {
 	resolver reflect.Value
 }
 
+var builtinTypes = map[string]iExec{
+	"Int":     &scalarExec{},
+	"Float":   &scalarExec{},
+	"String":  &scalarExec{},
+	"Boolean": &scalarExec{},
+	"ID":      &scalarExec{},
+}
+
 func Make(s *schema.Schema, resolver interface{}) (*Exec, error) {
 	implementsMap := make(map[string][]string)
 	for _, t := range s.Types {
@@ -55,9 +63,6 @@ func (e *Exec) Exec(document *query.Document, variables map[string]interface{},
 
 func makeExec(s *schema.Schema, t schema.Type, resolverType reflect.Type, implementsMap map[string][]string, typeRefMap map[typeRefMapKey]*typeRefExec) (iExec, error) {
 	switch t := t.(type) {
-	case *schema.Scalar:
-		return &scalarExec{}, nil
-
 	case *schema.Object:
 		fields := make(map[string]*fieldExec)
 		for name, f := range t.Fields {
@@ -113,6 +118,9 @@ func makeExec(s *schema.Schema, t schema.Type, resolverType reflect.Type, implem
 		}, nil
 
 	case *schema.TypeReference:
+		if builtin, ok := builtinTypes[t.Name]; ok {
+			return builtin, nil
+		}
 		e, err := resolveType(s, t.Name, resolverType, implementsMap, typeRefMap)
 		return e, err
 

diff --git a/internal/schema/schema.go b/internal/schema/schema.go
@@ -18,8 +18,6 @@ type Type interface {
 	isType()
 }
 
-type Scalar struct{}
-
 type Object struct {
 	Name       string
 	Implements string
@@ -44,7 +42,6 @@ type TypeReference struct {
 	Name string
 }
 
-func (Scalar) isType()        {}
 func (Object) isType()        {}
 func (Union) isType()         {}
 func (Enum) isType()          {}
@@ -215,13 +212,8 @@ func parseType(l *lexer.Lexer) Type {
 		return parseList(l)
 	}
 
-	name := l.ConsumeIdent()
-	switch name {
-	case "Int", "Float", "String", "Boolean", "ID":
-		return &Scalar{}
-	}
 	return &TypeReference{
-		Name: name,
+		Name: l.ConsumeIdent(),
 	}
 }