Skip to content

Commit

Permalink
address review comments
Browse files Browse the repository at this point in the history
- reworked code generation for federation.go
- better checking for missing/incorrect parameters to entity resolver functions
- better tests for generated entity resolvers

Still missing: 
- suggested test for autobind vs non-autobind generation
- could probably clean up generated code spacing, etc
- not sure @multi cases are handled completely (if they apply)
  • Loading branch information
carldunham authored and Carl Dunham committed Dec 1, 2021
1 parent 6fcc5f5 commit f46c6bb
Show file tree
Hide file tree
Showing 13 changed files with 1,438 additions and 303 deletions.
84 changes: 61 additions & 23 deletions example/federation/accounts/graph/generated/federation.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

152 changes: 113 additions & 39 deletions example/federation/products/graph/generated/federation.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit f46c6bb

Please sign in to comment.