Merge pull request #1288 from alexsn/nopath-field-noerror

avoid computing field path when getting field errors
99designs · Aug 18, 2020 · e3ce560 · e3ce560
2 parents 108975c + fd0f97c
commit e3ce560
Showing 1 changed file with 10 additions and 2 deletions.
diff --git a/graphql/context_response.go b/graphql/context_response.go
@@ -67,8 +67,12 @@ func HasFieldError(ctx context.Context, rctx *FieldContext) bool {
 
 	c.errorsMu.Lock()
 	defer c.errorsMu.Unlock()
-	path := rctx.Path()
 
+	if len(c.errors) == 0 {
+		return false
+	}
+
+	path := rctx.Path()
 	for _, err := range c.errors {
 		if equalPath(err.Path, path) {
 			return true
@@ -83,8 +87,12 @@ func GetFieldErrors(ctx context.Context, rctx *FieldContext) gqlerror.List {
 
 	c.errorsMu.Lock()
 	defer c.errorsMu.Unlock()
-	path := rctx.Path()
 
+	if len(c.errors) == 0 {
+		return nil
+	}
+
+	path := rctx.Path()
 	var errs gqlerror.List
 	for _, err := range c.errors {
 		if equalPath(err.Path, path) {