fix lint warning

99designs · Oct 31, 2018 · a905efa · a905efa
1 parent b2ba5f8
commit a905efa
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 4 deletions.
diff --git a/gqlapollotracing/extension.go b/gqlapollotracing/extension.go
@@ -6,7 +6,7 @@ import (
 )
 
 type tracingData struct {
-	mu sync.Mutex `json:"-"`
+	mu sync.Mutex
 
 	StartTime  time.Time     `json:"startTime"`
 	EndTime    time.Time     `json:"endTime"`
@@ -17,7 +17,7 @@ type tracingData struct {
 }
 
 func (td *tracingData) prepare() {
-	td.Duration = time.Time(td.EndTime).Sub(time.Time(td.StartTime))
+	td.Duration = td.EndTime.Sub(td.StartTime)
 	if td.Parsing != nil {
 		td.Parsing.prepare(td)
 	}
@@ -38,7 +38,7 @@ type startOffset struct {
 }
 
 func (so *startOffset) prepare(td *tracingData) {
-	so.StartOffset = time.Time(so.StartTime).Sub(time.Time(td.StartTime))
+	so.StartOffset = so.StartTime.Sub(td.StartTime)
 	so.Duration = so.EndTime.Sub(so.StartTime)
 }
 

diff --git a/gqlapollotracing/middleware.go b/gqlapollotracing/middleware.go
@@ -14,7 +14,10 @@ func RequestMiddleware() graphql.RequestMiddleware {
 		td := getTracingData(ctx)
 		td.prepare()
 
-		reqCtx.RegisterExtension("tracing", td)
+		err := reqCtx.RegisterExtension("tracing", td)
+		if err != nil {
+			reqCtx.Error(ctx, err)
+		}
 
 		return res
 	}