Update fileupload test to use GQLgen test client

Update the fileupload test to use the GQLgen test client and `WithFiles`
option to remove the need for `createUploadRequest` helper with raw http
posts

- Fix setting the Content Type by using the appropriate `http` package
  function to dectect it

  + https://godoc.org/net/http#DetectContentType

client/withfilesoption.go

@@ -6,6 +6,7 @@ import (
 	"fmt"
 	"io/ioutil"
 	"mime/multipart"
+	"net/http"
 	"net/textproto"
 	"os"
 	"strings"
@@ -74,14 +75,16 @@ func WithFiles() Option {
 
 		// --b7955bd2e1d17b67ac157b9e9ddb6238888caefc6f3541920a1debad284d
 		// Content-Disposition: form-data; name="0"; filename="tempFile"
+		// Content-Type: text/plain; charset=utf-8
+		// or
 		// Content-Type: application/octet-stream
 		//
 		for i, fileData := range filesData {
 			h := make(textproto.MIMEHeader)
 			h.Set("Content-Disposition", fmt.Sprintf(`form-data; name="%d"; filename="%s"`, i, fileData.file.Name()))
-			h.Set("Content-Type", "application/octet-stream")
-			ff, _ := bodyWriter.CreatePart(h)
 			b, _ := ioutil.ReadFile(fileData.file.Name())
+			h.Set("Content-Type", http.DetectContentType(b))
+			ff, _ := bodyWriter.CreatePart(h)
 			ff.Write(b)
 		}
 		bodyWriter.Close()

example/fileupload/fileupload_test.go

@@ -11,8 +11,10 @@ import (
 	"net/http"
 	"net/http/httptest"
 	"net/textproto"
+	"os"
 	"testing"
 
+	gqlclient "github.com/99designs/gqlgen/client"
 	"github.com/99designs/gqlgen/example/fileupload/model"
 	"github.com/99designs/gqlgen/graphql"
 	"github.com/99designs/gqlgen/graphql/handler"
@@ -22,9 +24,12 @@ import (
 
 func TestFileUpload(t *testing.T) {
 	client := http.Client{}
+	resolver := &Stub{}
+	srv := httptest.NewServer(handler.NewDefaultServer(NewExecutableSchema(Config{Resolvers: resolver})))
+	defer srv.Close()
+	gql := gqlclient.New(srv.Config.Handler, gqlclient.Path("/graphql"))
 
 	t.Run("valid single file upload", func(t *testing.T) {
-		resolver := &Stub{}
 		resolver.MutationResolver.SingleUpload = func(ctx context.Context, file graphql.Upload) (*model.File, error) {
 			require.NotNil(t, file)
 			require.NotNil(t, file.File)
@@ -39,30 +44,29 @@ func TestFileUpload(t *testing.T) {
 				ContentType: file.ContentType,
 			}, nil
 		}
-		srv := httptest.NewServer(handler.NewDefaultServer(NewExecutableSchema(Config{Resolvers: resolver})))
-		defer srv.Close()
 
-		operations := `{ "query": "mutation ($file: Upload!) { singleUpload(file: $file) { id, name, content, contentType } }", "variables": { "file": null } }`
-		mapData := `{ "0": ["variables.file"] }`
-		files := []file{
-			{
-				mapKey:      "0",
-				name:        "a.txt",
-				content:     "test",
-				contentType: "text/plain",
-			},
+		mutation := `mutation ($file: Upload!) {
+			singleUpload(file: $file) {
+				id
+				name
+				content
+				contentType
+			}
+		}`
+		var result struct {
+			SingleUpload *model.File
 		}
-		req := createUploadRequest(t, srv.URL, operations, mapData, files)
 
-		resp, err := client.Do(req)
-		require.Nil(t, err)
-		require.Equal(t, http.StatusOK, resp.StatusCode)
-		responseBody, err := ioutil.ReadAll(resp.Body)
-		require.Nil(t, err)
-		responseString := string(responseBody)
-		require.Equal(t, `{"data":{"singleUpload":{"id":1,"name":"a.txt","content":"test","contentType":"text/plain"}}}`, responseString)
-		err = resp.Body.Close()
+		aFile, _ := ioutil.TempFile(os.TempDir(), "aFile")
+		defer os.Remove(aFile.Name())
+		aFile.WriteString(`test`)
+
+		err := gql.Post(mutation, &result, gqlclient.Var("file", aFile), gqlclient.WithFiles())
 		require.Nil(t, err)
+		require.Equal(t, 1, result.SingleUpload.ID)
+		require.Contains(t, result.SingleUpload.Name, "aFile")
+		require.Equal(t, "test", result.SingleUpload.Content)
+		require.Equal(t, "text/plain; charset=utf-8", result.SingleUpload.ContentType)
 	})
 
 	t.Run("valid single file upload with payload", func(t *testing.T) {