Fix #1203 Null input for slice should convert to nil rather than a em…

…pty slice not change IsNilable because other tests will fail if we do
99designs · Jun 2, 2020 · 422ab49 · 422ab49
1 parent d3bfc92
commit 422ab49
Show file tree

Hide file tree

Showing 17 changed files with 118 additions and 3 deletions.
diff --git a/codegen/testserver/generated.go b/codegen/testserver/generated.go
diff --git a/codegen/type.gotpl b/codegen/type.gotpl
@@ -8,6 +8,7 @@
 				res, err := ec.{{ $type.Elem.UnmarshalFunc }}(ctx, v)
 				return &res, err
 			{{- else if $type.IsSlice }}
+			    if v == nil { return nil, nil }
 				var vSlice []interface{}
 				if v != nil {
 					if tmp1, ok := v.([]interface{}); ok {

diff --git a/example/chat/generated.go b/example/chat/generated.go
diff --git a/example/config/generated.go b/example/config/generated.go
diff --git a/example/dataloader/generated.go b/example/dataloader/generated.go
diff --git a/example/federation/accounts/graph/generated/generated.go b/example/federation/accounts/graph/generated/generated.go
diff --git a/example/federation/products/graph/generated/generated.go b/example/federation/products/graph/generated/generated.go
diff --git a/example/federation/reviews/graph/generated/generated.go b/example/federation/reviews/graph/generated/generated.go
diff --git a/example/fileupload/generated.go b/example/fileupload/generated.go
diff --git a/example/scalars/generated.go b/example/scalars/generated.go
diff --git a/example/selection/generated.go b/example/selection/generated.go
diff --git a/example/starwars/generated/exec.go b/example/starwars/generated/exec.go
diff --git a/example/todo/generated.go b/example/todo/generated.go
diff --git a/example/type-system-extension/generated.go b/example/type-system-extension/generated.go
diff --git a/integration/generated.go b/integration/generated.go
diff --git a/plugin/resolvergen/testdata/followschema/out/resolver.go b/plugin/resolvergen/testdata/followschema/out/resolver.go
@@ -1,6 +1,7 @@
+package customresolver
+
 // This file will not be regenerated automatically.
 //
 // It serves as dependency injection for your app, add any dependencies you require here.
-package customresolver
 
 type CustomResolverType struct{}