-
Notifications
You must be signed in to change notification settings - Fork 821
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[login] allow sourcing STS credentials from environment (closes #861) #864
[login] allow sourcing STS credentials from environment (closes #861) #864
Conversation
Hmm I wonder if That would also allow workflows such as $ aws-vault exec foo
foo $ aws s3 ls
foo $ aws-vault login Where aws-vault could use the environment to login from within an exec subshell. Any downsides to that approach? |
Good point, and it's a workflow I've needed multiple times. The only downside I see is that if you run |
Done in bfbbfda, let me know how that looks! |
@mtibben I've been using this feature locally for a few days, works great for me. Let me know if you require any changes! |
@mtibben Eager to get this merged as I'm using it every day and I'm sure it will be useful to other folks. :) Let me know any way I can help! |
9d26b0e
to
d07990f
Compare
Thanks for the review, when's the next release planned for? |
Out now! I made one modification to the error message - hope this is OK? 67d1aea |
No strong opinion. Having this behavior in usage docs would have made it easier to discover, possibly? |
Sample usage:
Sample error:
Main use-case: Allow generating sign-in links when temporary credentials have been obtained from another way than aws-vault. There is third-party tooling doing it such as https://github.com/NetSPI/aws_consoler, but I feel like it's worth it to have it built in aws-vault.
Notes:
login --from-env
with only IAM credentials, it would a bit more complex (retrieve from environment, then use theGetFederationToken
provider) for something that IMHO doesn't add value. If you have IAM credentials, they are long-lived by definition and they should be managed through aws-vault anyway