Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

newline added to end of parent_profile deprecation warning #653

Merged
merged 1 commit into from
Sep 9, 2020
Merged

newline added to end of parent_profile deprecation warning #653

merged 1 commit into from
Sep 9, 2020

Conversation

rossmckelvie
Copy link
Contributor

Fixing a small pet peeve of mine, where I am still using parent_profile for IAM-configured profiles that haven't been converted to their SSO equivalents yet.

In v6.0.0, when using a profile that has a parent, the MFA prompt or first output of the command is written to the same line in my terminal, ex:

❯ aws-vault exec test -- terraform plan
Warning: parent_profile is deprecated, please use include_profile instead in your AWS configEnter token for arn:aws:iam::0123456789012:mfa/forename.surename: 000000
Refreshing Terraform state in-memory prior to plan...

This commit adds a new line so that the warning appears on it's own line:

❯ aws-vault exec test -- terraform plan
Warning: parent_profile is deprecated, please use include_profile instead in your AWS config
Enter token for arn:aws:iam::0123456789012:mfa/forename.surename: 000000
Refreshing Terraform state in-memory prior to plan...

@mtibben mtibben merged commit c477911 into 99designs:master Sep 9, 2020
@rossmckelvie rossmckelvie deleted the bug_parent_profile_missing_newline branch September 9, 2020 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants