Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a prompt that is native to Windows #613

Merged
merged 3 commits into from
Aug 16, 2020

Conversation

BradBarnich
Copy link
Contributor

This solved a pain point for me when using aws-vault on windows as a credential helper, since the console prompt doesn't work in that scenario.

Forgive me, this is the first Go code that I've ever written. Hope it can be worked into something mergeable

Thanks

@mtibben
Copy link
Member

mtibben commented Aug 16, 2020

Thanks @BradBarnich! I made a few tweaks to remove the use of globals and renamed to credui to be more specific - i.e. how "native" is it? Does this work with every type of windows - windows xp, windows IoT?

@mtibben mtibben merged commit 9390283 into 99designs:master Aug 16, 2020
@BradBarnich
Copy link
Contributor Author

Thank you!

It is an older API, so I presume it is fairly compatible. But I don’t know.

@mtibben mtibben added this to the v6 milestone Aug 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants