refactor prompts to mfa-token-providers #533
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prompts were simple prompts, mfa token providers have the `mfa_serial` that the token is being requested for. It may simply be used to display to the user, or could be passed to the store in order to lookup the correct creds. This enables the interfacing of apps/stores that manage multiple mfa creds/secrets, examples of such stores may be bitwarden, ykman. The --prompt flag becomes --mfa-token-provider and AWS_VAULT_PROMPT is changed to AWS_VAULT_MFA_TOKEN_PROVIDER.
j0hnsmith
force-pushed
the
refactor_prompts
branch
from
768c9ed
to
78573db
Compare
seh
reviewed
Feb 27, 2020
seh
reviewed
Feb 27, 2020
seh
reviewed
Feb 27, 2020
cli/global.go
Outdated
| PassPrefix string | ||
| Debug bool | ||
| Backend string | ||
| MfaTokenProvider string |
There was a problem hiding this comment.
Suggested change
| MfaTokenProvider string | |
| MFATokenProvider string |
seh
reviewed
Feb 27, 2020
Co-Authored-By: Steven E. Harris <[email protected]>
Co-Authored-By: Steven E. Harris <[email protected]>
Co-Authored-By: Steven E. Harris <[email protected]>
|
@seh thanks for review, changes made 👍 |
|
Hi, I came across this PR in my journey to find a nicer way to use my Yubikey with |
Merged
|
Fixed in #558 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prompts were simple prompts, mfa token providers have the
mfa_serialthat the token is being requested for. It may simply be used to display
to the user, or could be passed to the store in order to lookup the
correct creds. This enables the interfacing of apps/stores that manage
multiple mfa creds/secrets, examples of such stores may be bitwarden,
ykman.
The --prompt flag becomes --mfa-token-provider and AWS_VAULT_PROMPT is
changed to AWS_VAULT_MFA_TOKEN_PROVIDER.