Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add service option initially implemented by @maishsk #291

Merged
merged 2 commits into from
Oct 12, 2018

Conversation

frezbo
Copy link
Contributor

@frezbo frezbo commented Sep 23, 2018

This is a feature enhance to #278 by @maishsk. Thanks a lot for the idea. I tested this both in commercial and gov-cloud region and seems to work like a charm. This also takes cares of the region issue as per #285 .

@mtibben
Copy link
Member

mtibben commented Sep 26, 2018

Seems like most, but not all, AWS services have the URL form https://{host}/{service}/home, though /{service} seems to redirect

Is --service right here, or would something like --url-path be clearer about what this is for? It's possible to deep link into a particular URL in aws web console using this flag too, which service doesn't capture

@frezbo
Copy link
Contributor Author

frezbo commented Sep 27, 2018

@mtibben so you want service along with --url-path for nested services. BTW nice idea. I will try to see if I can spend some time on this.

@mtibben
Copy link
Member

mtibben commented Oct 5, 2018

I was thinking just --url-path (or maybe just --path), no need for --service because something like --path=ec2 redirects to the right place anyway

@frezbo
Copy link
Contributor Author

frezbo commented Oct 5, 2018

@mtibben I have updated service to path

@maishsk
Copy link

maishsk commented Oct 5, 2018

👍
LGTM

@mtibben mtibben merged commit fe07bd0 into 99designs:master Oct 12, 2018
@mtibben mtibben mentioned this pull request Oct 12, 2018
@frezbo frezbo deleted the feature/service branch October 14, 2018 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants