Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump keyring version #193

Merged
merged 7 commits into from
Dec 5, 2017
Merged

Bump keyring version #193

merged 7 commits into from
Dec 5, 2017

Conversation

lox
Copy link
Collaborator

@lox lox commented Nov 26, 2017

This updates to the latest https://github.com/99designs/keyring API, which is a fairly major change. I've checked that we are setting the correct defaults so that it's backwards compatible on everything but kwallet and libsecret, but have eyeballed them.

Closes #188.

@lox lox requested review from vektah and mtibben November 26, 2017 23:34
@lox
Copy link
Collaborator Author

lox commented Dec 3, 2017

I'm going to merge this next week, let me know if there are any objections @vektah / @mtibben

@lox lox merged commit 7327365 into master Dec 5, 2017
@pda
Copy link
Collaborator

pda commented Dec 5, 2017

Nice work 🎉

@porty porty deleted the bump-keyring-version branch January 12, 2018 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants