Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix data race #162

Merged
merged 1 commit into from
Oct 12, 2017
Merged

Fix data race #162

merged 1 commit into from
Oct 12, 2017

Commits on Oct 12, 2017

  1. Fix data race

    We try to read cmd.Process in the thread that handles incoming
    signals, but there's no synchronization between that goroutine and the
    one that sets cmd.Process to a non-nil value.
    
    This might be overkill, e.g. there may be a way to write this with
    less code, but I confirmed that this patch addresses the
    race when shutting down the program.
    
    Fixes 99designs#158.
    kevinburke committed Oct 12, 2017
    Configuration menu
    Copy the full SHA
    e7a769f View commit details
    Browse the repository at this point in the history