Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify credentials, sessions and profiles #161

Merged
merged 7 commits into from
Oct 18, 2017

Conversation

lox
Copy link
Collaborator

@lox lox commented Oct 11, 2017

Closes #137. Relates to #160.

General cleanup of profile / config parsing code. Implements the list command with tabular output:

Profile                   Credentials              Sessions
=======                   ===========              ========
ljd                       ljd                      61343032633337323134, 32663735326133373631, 61633665646639303539
ljd-admin                 ljd                      61343032633337323134, 32663735326133373631, 61633665646639303539
xyz                       ljd                      61343032633337323134, 32663735326133373631, 61633665646639303539

This of course begs the question, why do we have so many old sessions hanging around?

@lox lox force-pushed the clarify-credentials-sessions-and-profiles branch from db73b84 to ff66343 Compare October 11, 2017 21:41
@lox lox changed the title Clarify credentials sessions and profiles Clarify credentials, sessions and profiles Oct 12, 2017
@lox lox force-pushed the clarify-credentials-sessions-and-profiles branch from 1cb7512 to c851695 Compare October 12, 2017 11:32
@lox lox requested a review from mtibben October 12, 2017 11:35
@mtibben
Copy link
Member

mtibben commented Oct 12, 2017

So if I understand correctly - Profile is what's in config, Credentials is the ID for the credentials aws-vault stores (and uses to generate the session), and will correspond to the profile name or the source_profile if that's being used

It seems the challenge is working out the right UI to disambiguate between profiles/credentials and make users aware of this nuance, so this is definitely an improvement on what we currently have.

So because it seems this command is using profiles as it's main starting point, does this command list all profiles in config, or just profiles we have credentials stored for?

@mtibben
Copy link
Member

mtibben commented Oct 12, 2017

Ha I just realised you asked the same question #137 (comment)

@lox
Copy link
Collaborator Author

lox commented Oct 12, 2017

Yeah, I decided c) all of the above. It will show profiles in your config and it will show credentials without a profile in the config. The only thing it won't do is show sessions that don't have a config entry.

@lox
Copy link
Collaborator Author

lox commented Oct 12, 2017

I'm going to automatically add a config entry with the add command to keep things consistent.

@lox lox merged commit eb8b1dc into master Oct 18, 2017
@lox lox deleted the clarify-credentials-sessions-and-profiles branch October 18, 2017 02:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants