Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove use of old env vars #1143

Merged
merged 1 commit into from
Feb 18, 2023
Merged

Remove use of old env vars #1143

merged 1 commit into from
Feb 18, 2023

Conversation

mtibben
Copy link
Member

@mtibben mtibben commented Feb 18, 2023

Remove use of unnecessary env vars.

  • AWS_DEFAULT_REGION: use AWS_REGION instead. AWS_DEFAULT_REGION set the "default" region, and is unnecessary
  • AWS_SECURITY_TOKEN: use AWS_SESSION_TOKEN instead
  • AWS_SESSION_EXPIRATION: use AWS_CREDENTIAL_EXPIRATION instead

@mtibben mtibben merged commit 978559b into master Feb 18, 2023
@mtibben mtibben deleted the rm-old-env-vars branch February 18, 2023 02:28
@mtibben mtibben mentioned this pull request Feb 20, 2023
Merged
@bongole bongole mentioned this pull request Mar 8, 2023
Closed
ismailyenigul added a commit to ismailyenigul/theme-bobthefish that referenced this pull request Mar 28, 2023
@ismailyenigul
replace AWS_SESSION_EXPIRATION
2ddb505 
aws-vault 7.X removed  AWS_SESSION_EXPIRATION env and replaced with AWS_CREDENTIAL_EXPIRATION
to make this theme work for aws-vault 7.X, we must replace this env.

see: 99designs/aws-vault#1143
@ismailyenigul ismailyenigul mentioned this pull request Mar 28, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mtibben