When using a subshell, add some help messages to minimise confusion and improve DX #1136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtibben
force-pushed
the
feedback-on-shell
branch
from
ea2a98b
to
439d7a1
Compare
mtibben
changed the title
This was referenced Feb 17, 2023
mtibben
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
aws-vault has traditionally stuck to the unix philosophy of "silence is golden". However there are a number of scenarios which consistently confuse users.
SHELLand creates a subshell when a command isn't provided--ec2-serverAWS_CONTAINER_CREDENTIALS_FULL_URIwhen using--ecs-serverFor that reason, this PR changes aws-vault to provide minimalistic feedback to the user when these scenarios come up.