simple bug and am close (hopefully 😁) to making PR: login command hangs if profile doesn't exist

[matthewliuswims]

• I am using the latest release of AWS Vault
• I have provided my .aws/config (redacted if necessary)
• I have provided the debug output using aws-vault --debug (redacted if necessary)

bug/replication

aws-vault login <non-existent-profile> hangs forever if profile doesn't exist 😓

fix attempt

I did some digging: the hang is caused by infinite recursion here

aws-vault/vault/vault.go

Lines 220 to 231 in 1ce3655

	func MasterCredentialsFor(profileName string, keyring *CredentialKeyring, config *Config) (string, error) {
	hasMasterCreds, err := keyring.Has(profileName)
	if err != nil {
	return "", err
	}
	if hasMasterCreds {
	return profileName, nil
	}
	return MasterCredentialsFor(config.SourceProfileName, keyring, config)
	}

hasMasterCreds, err := keyring.Has(profileName)  // the culprit
// hasMasterCreds, err end up being false and nil respectively forever and ever

func is called here

aws-vault/vault/vault.go

Lines 196 to 197 in 1ce3655

	func NewFederationTokenCredentials(profileName string, k *CredentialKeyring, config *Config) (*credentials.Credentials, error) {
	credentialsName, err := MasterCredentialsFor(profileName, k, config)

I'm happy to make a pr, but i'm not sure what kind of base case checking I should be doing for MasterCredentialsFor func without breaking functionality

Thank you!

[mtibben]

A PR would certainly be welcome! Get something going and we can discuss

[mtibben]

How's that PR coming along @matthewliuswims? :)

[mtibben]

Possible solution here? #507 (comment)

[matthewliuswims]

ah yes - that looks like a great fix. :) gonna do some testing and i'll hopefully put in a PR today!

[matthewliuswims]

@mtibben PR here https://github.com/99designs/aws-vault/pull/575/files !

[mtibben]

Fixed in 1496990