Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: manual-discovery with node tags #84

Merged

Conversation

giangndm
Copy link
Contributor

@giangndm giangndm commented Nov 28, 2023

This merge implement a discovery mechanism which use tag for finding which node should be connected to.

  • Each node has multi string local-tags, and set to multi-hash-map: SetH(hash(tag), node_id, node_addr).
  • Each node has multi string connect-tags, and sub to multi-hash-map: SubH(hash(tag)).

By that way, each node will received node_id and node_addr of all node which interested by connect-tags, and using the addr to connect to.

Copy link

codecov bot commented Nov 28, 2023

Codecov Report

Attention: 23 lines in your changes are missing coverage. Please review.

Comparison is base (36b4895) 86.31% compared to head (9dfa2ee) 86.48%.

Files Patch % Lines
packages/services/manual_discovery/src/behavior.rs 89.95% 22 Missing ⚠️
packages/integration_tests/src/pubsub.rs 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #84      +/-   ##
==========================================
+ Coverage   86.31%   86.48%   +0.17%     
==========================================
  Files         106      107       +1     
  Lines       12265    12486     +221     
==========================================
+ Hits        10586    10798     +212     
- Misses       1679     1688       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@giangndm giangndm marked this pull request as ready for review November 28, 2023 07:24
@giangndm giangndm merged commit 115dd25 into 8xFF:master Nov 28, 2023
5 checks passed
@giangndm
Copy link
Contributor Author

close #49

This was referenced Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant