fix: key-value event not fired with second subs #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #79 +/- ##
==========================================
+ Coverage 86.04% 86.21% +0.17%
==========================================
Files 106 106
Lines 12192 12265 +73
==========================================
+ Hits 10490 10574 +84
+ Misses 1702 1691 -11 ☔ View full report in Codecov by Sentry. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -9,8 +9,7 @@ | |||
| use parking_lot::RwLock; | |||
|
|
|||
| struct SubscribeContainer<T> { | |||
| subscribers: HashMap<u64, Sender<T>>, | |||
| clear_handler: Box<dyn FnOnce() + Send + Sync>, | |||
| subscribers: HashMap<u64, (Sender<T>, Box<dyn FnOnce() + Send + Sync>)>, | |||
Check warning
Code scanning / clippy
very complex type used. Consider factoring parts into type definitions Warning
Merged
This was referenced Nov 23, 2023
Only first peer is fired with KeyValue event, from seconds user not fired
8xFF/atm0s-media-server#75
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.