-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: clippy fixes #167
chore: clippy fixes #167
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have some questions.
@dhilipsiva It look like have conflicts after I merge some changes from media-server patch. Can you look at it? |
@giangndm I have carefully resolved all the conflicts and fixed clippy warnings in the media-server patch. If everything looks good to you, we can merge this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I only have some comments and discussions
@dhilipsiva Cargo-deny is feedback some warns, then we should have some config like media-server has |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for carefully resolved all comments. I will merge it now.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #167 +/- ##
==========================================
+ Coverage 83.21% 83.28% +0.06%
==========================================
Files 68 68
Lines 9038 9016 -22
==========================================
- Hits 7521 7509 -12
+ Misses 1517 1507 -10 ☔ View full report in Codecov by Sentry. |
@dhilipsiva We have some packages which rejected by cargo-deny, can you create a config for cargo-deny like this: https://github.com/8xFF/atm0s-media-server/blob/master/deny.toml |
@dhilipsiva thank you so much. |
No description provided.