fix: missing register service (#85)

8xFF · Nov 28, 2023 · 4799a77 · 4799a77
1 parent 115dd25
commit 4799a77
Show file tree

Hide file tree

Showing 5 changed files with 11 additions and 4 deletions.
diff --git a/packages/core/router/src/force_local.rs b/packages/core/router/src/force_local.rs
@@ -7,6 +7,8 @@ use crate::{RouteAction, RouterTable};
 pub struct ForceLocalRouter();
 
 impl RouterTable for ForceLocalRouter {
+    fn register_service(&self, _service_id: u8) {}
+
     fn path_to_node(&self, _dest: NodeId) -> RouteAction {
         RouteAction::Local
     }

diff --git a/packages/core/router/src/force_node.rs b/packages/core/router/src/force_node.rs
@@ -7,6 +7,8 @@ use crate::{RouteAction, RouterTable};
 pub struct ForceNodeRouter(pub ConnId, pub NodeId);
 
 impl RouterTable for ForceNodeRouter {
+    fn register_service(&self, _service_id: u8) {}
+
     fn path_to_node(&self, _dest: NodeId) -> RouteAction {
         RouteAction::Next(self.0, self.1)
     }

diff --git a/packages/core/router/src/lib.rs b/packages/core/router/src/lib.rs
@@ -46,6 +46,8 @@ impl RouteAction {
 
 #[cfg_attr(any(test, feature = "mock"), automock)]
 pub trait RouterTable: Send + Sync {
+    /// Register service
+    fn register_service(&self, service_id: u8);
     /// Determine the next action for the given destination node
     fn path_to_node(&self, dest: NodeId) -> RouteAction;
     /// Determine the next action for the given key

diff --git a/packages/network/src/plane.rs b/packages/network/src/plane.rs
@@ -123,6 +123,7 @@ where
 
         let mut new_behaviours = vec![];
         for behaviour in conf.behaviors {
+            conf.router.register_service(behaviour.service_id());
             let awake = BehaviourAwake {
                 service_id: behaviour.service_id(),
                 bus: bus.clone(),

diff --git a/packages/routers/layers_spread_router/src/shared.rs b/packages/routers/layers_spread_router/src/shared.rs
@@ -28,10 +28,6 @@ impl SharedRouter {
         self.router.read().size()
     }
 
-    pub fn register_service(&self, service_id: u8) {
-        self.router.write().register_service(service_id)
-    }
-
     pub fn service_next(&self, service_id: u8, excepts: &[NodeId]) -> Option<ServiceDestination> {
         self.router.read().service_next(service_id, excepts)
     }
@@ -74,6 +70,10 @@ impl SharedRouter {
 }
 
 impl RouterTable for SharedRouter {
+    fn register_service(&self, service_id: u8) {
+        self.router.write().register_service(service_id)
+    }
+
     fn path_to_node(&self, dest: NodeId) -> RouteAction {
         if self.node_id == dest {
             return RouteAction::Local;