Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: init-container when using dynamic persistence #82

Merged
merged 2 commits into from
Mar 15, 2024
Merged

feat: init-container when using dynamic persistence #82

merged 2 commits into from
Mar 15, 2024

Conversation

Karitham
Copy link
Contributor

@Karitham Karitham commented Mar 14, 2024 •
edited
Loading

Hi,

This is my first time contributing to a helm chart so I may have missed some parts.

I've tested this change with the following helmfile

releases:
  - name: n8n-test
    namespace: n8n-test
    chart: ./n8n-0.23.0.tgz
    values:
      - persistence:
          enabled: true
          type: dynamic
          storageClass: "standard"
          size: 10Gi

And ran helm lint.

Let me know if I'm missing something, happy to fix.

Closes #71

@Karitham Karitham requested a review from a team as a code owner March 14, 2024 11:29
Vad1mo
Vad1mo reviewed Mar 14, 2024
View reviewed changes
Copy link
Member

@Vad1mo Vad1mo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks for the PR, this looks good so far! just a couple of changes needed.

templates/deployment.yaml Outdated Show resolved Hide resolved
Chart.yaml Outdated Show resolved Hide resolved
@Karitham
fix: use n8n image instead of busybox
5231391 
- 8gears#82 (comment)

fix the artifacthub.io/changes in `Chart.yaml`

- 8gears#82 (comment)
@Vad1mo Vad1mo merged commit f50ba42 into 8gears:master Mar 15, 2024
@Vad1mo
Copy link
Member

Vad1mo commented Mar 16, 2024

fyi. fix is out and in chart version 0.22.1. Was no need to bump the file

@fk-flip fk-flip mentioned this pull request Apr 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Vad1mo Vad1mo Vad1mo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Permission denied when using persistent volumes
2 participants
@Karitham @Vad1mo