Make PlantumlDiagram public so that ToPumlString method is accessible #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @yanjustino, could you take a look at this PR? Thanks! |
|
Thank you for your contribution, @BenRStutzman! I believe that your submission will bring many benefits to library users! |
|
Soon I will release a new version |
|
Great, thanks @yanjustino! I have a couple other ideas for changes that I'll make PRs for in a bit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make
PlantumlDiagrampublic so that itsToPumlStringmethod is accessible from outside of this library - it's useful for creating a puml string when you don't want to save it to a file or export it to a PNG (for example, in my project I want to post the puml string to an external server, so all I need is the string).