Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Match Branch when checking for PR #127

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

8BitJonny
Copy link
Owner

@8BitJonny 8BitJonny commented Aug 17, 2022

Proposed changes

Fixes #8

This PR would introduce changes to match the underlying PR the job is running on and the found PRs.
This way, a single commit that would be pushed to two different branches would create two different outputs of this job, depending on if each branch had a PR and not if a PR was existent globally no matter on which branch.

Types of changes

What types of changes does your code introduce ?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

It is yet to nail down, if this should create a breaking change and a full version upgrade to v3 since this behaviour makes sense as a new default behaviour.

Or, if for now we introduce this as a non breaking change and keep the default behaviour of not matching the branch and then exposing a new input variable, possibly named matchBranch, that enables this behaviour for the extra special use cases.

Open Todo's

  • Implement the logic
  • Decide on a version (3.0.0 if breaking change, 2.2.0 if non-breaking change)
  • Update documentation
  • Add Test Cases

@8BitJonny 8BitJonny added the help wanted Extra attention is needed label Aug 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Proposal: Match Branch when checking for PR
1 participant