Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Proposal: Match Branch when checking for PR #8

Open
jeacott1 opened this issue Oct 14, 2020 · 1 comment · May be fixed by #127
Open

Feature Proposal: Match Branch when checking for PR #8

jeacott1 opened this issue Oct 14, 2020 · 1 comment · May be fixed by #127
Labels
enhancement New feature or request help wanted Extra attention is needed opinion wanted

Comments

@jeacott1
Copy link

if I have 2 branches, one with a PR associated with it, and one not,
and I push the same commit to both branches in github.

expected - when the action executes one of the branches should detects a PR exists and return a number, the other one should not.

actual - both branches find the same associated PR and return the same associated PR number.

this makes using this scheme kinda dangerous, as side-effects - publishing, overwriting pre-release artifacts etc will occur from unexpected branches.

a convenience option to compare the head.label or ref with the current branch would be very helpful.

@8BitJonny
Copy link
Owner

That would be definitely a good improvement for this project. I don't yet know how easy it is too implement this, as I had a long brake from working on this project and the github api.

I'm currently also swamped at Work so I won't be able to look into it in the next days. But nice feature request. At some point in time I'd like to have this in the repo 👍🏼

@8BitJonny 8BitJonny added enhancement New feature or request help wanted Extra attention is needed labels May 8, 2021
@8BitJonny 8BitJonny linked a pull request Aug 17, 2022 that will close this issue
10 tasks
@8BitJonny 8BitJonny pinned this issue Aug 17, 2022
@8BitJonny 8BitJonny changed the title same commit pushed to different branches yields the same PR Feature Proposal: Match Branch when checking for PR Aug 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed opinion wanted
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants