-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for loud comments #101
Conversation
@simoneldevig hi! Thank you for PR. |
@7rulnik I've tried to change it to use includes, but since the text that does not contain flexibility-disable is undefined it means that it would require an ekstra check anyways? :-) |
@simoneldevig you can use default argument |
Changes Unknown when pulling 84cced6 on nozebra:loud-comment-support into ** on 7rulnik:master**. |
Changes Unknown when pulling 84cced6 on nozebra:loud-comment-support into ** on 7rulnik:master**. |
@7rulnik I've changed the check to use endsWith since I ran in some issues with includes on not loud comments. I also added a test for loud comments as well :-) |
@simoneldevig nice! Thank you for tests. I will merge and release it at saturday. |
@simoneldevig just released it in 1.0.1. Thanks! |
It is very important the add support for loud comments when working in production environments since normal comments are removed when compiling sass with as compressed.