Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subcontext: add unsafeModify. Open SubcontextImpl class. Rename SubcontextImpl .empty->.initial #2225

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

neko-kai
Copy link
Member

@neko-kai neko-kai commented Dec 11, 2024

No description provided.

open SubcontextImpl class
rename SubcontextImpl `.empty`->`.initial`
@neko-kai neko-kai requested a review from pshirshov as a code owner December 11, 2024 13:34
@neko-kai
Copy link
Member Author

Actually we can't really add flatAp, because we can't expand the set of roots - the plan is already pre-planned with current roots. Any new components requested in flatAp would have to have already been dependencies of A or they wouldn't be found.

Copy link

codecov bot commented Dec 11, 2024

Codecov Report

Attention: Patch coverage is 40.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 66.71%. Comparing base (2f91adb) to head (f8170a1).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2225      +/-   ##
===========================================
- Coverage    66.72%   66.71%   -0.02%     
===========================================
  Files          594      594              
  Lines        11629    11631       +2     
  Branches      1394     1316      -78     
===========================================
  Hits          7760     7760              
- Misses        3869     3871       +2     

@neko-kai neko-kai changed the title Subcontext: add modify and flatAp methods Subcontext: add unsafeModify. Open SubcontextImpl class. Rename SubcontextImpl .empty->.initial Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant