Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix crash on init #24

Merged
merged 3 commits into from
Oct 30, 2024
Merged

Fix crash on init #24

merged 3 commits into from
Oct 30, 2024

Conversation

mingmingrr
Copy link
Contributor

See #23

@con-f-use
Copy link
Collaborator

con-f-use commented Oct 30, 2024 •
edited
Loading

Did you test this for non-mac systems?

This is on MacOS (Sonoma 14.6.1), under zsh, python 3.12.2 or 3.13.0.

I'm kinda curious about the Mac + zsh part here. Also please add yourself to the contributors in the readme, make a changelog entry there and bump the patch version in setup.py.

@mingmingrr
Copy link
Contributor Author

mingmingrr commented Oct 30, 2024 •
edited
Loading

I tested this on NixOS 24.11 with python 3.12.6, launching xonsh 0.18.3 from fish. Saw the same behavior so I don't think it's something to do with MacOS or zsh.

@con-f-use con-f-use merged commit ec0e13b into 74th:master Oct 30, 2024
@con-f-use
Copy link
Collaborator

con-f-use commented Oct 30, 2024 •
edited
Loading

Did a quick test and doesn't seem to break anything for me either. Thanks for the fix!

@con-f-use con-f-use self-assigned this Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@con-f-use con-f-use

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mingmingrr @con-f-use