Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improves comment handling in CommonJS import transformation #41

Merged
merged 1 commit into from
May 22, 2017
Merged

Improves comment handling in CommonJS import transformation #41

merged 1 commit into from
May 22, 2017

Conversation

jsnmoon
Copy link
Collaborator

@jsnmoon jsnmoon commented Mar 27, 2017

Fixes two known issues and added a corresponding test.

@jsnmoon
Copy link
Collaborator Author

jsnmoon commented May 22, 2017

Howdy @xjamundx and @gmathieu, do you think we could merge this in? (The branch has been rebased off of master.)

@xjamundx
Copy link
Contributor

This is pretty sweet

@xjamundx
Copy link
Contributor

ooops, we just merged some other stuff in. if you get this rebased today I'll merge and publish them all together.

@jsnmoon
Copy link
Collaborator Author

jsnmoon commented May 22, 2017

Got it! I'll go ahead and rebase this in a few minutes.

@jsnmoon
Copy link
Collaborator Author

jsnmoon commented May 22, 2017

Rebase complete!

@xjamundx xjamundx merged commit 5e285c6 into 5to6:master May 22, 2017
@xjamundx
Copy link
Contributor

I will try to publish these changes in the next 30 minutes

@jsnmoon jsnmoon deleted the imports-comment-enhancement branch May 22, 2017 18:09
@xjamundx
Copy link
Contributor

@xjamundx
Copy link
Contributor

published

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants