Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply fixes from StyleCI #165

Merged
merged 1 commit into from
Jul 21, 2023

Conversation

mechelon
Copy link
Member

This pull request applies code style fixes from an analysis carried out by StyleCI.


For more information, click here.

@mechelon mechelon merged commit c9fe4c6 into feature/retrieve-page-property-items Jul 21, 2023
@mechelon mechelon deleted the analysis-6VDRbl branch July 21, 2023 14:13
@what-the-diff
Copy link

what-the-diff bot commented Jul 21, 2023

PR Summary

  • Refinement in Code Comments in src/Endpoints/Page.php
    The comments for ‘property’ method have been updated for better clarity and understanding of the process. Also, a new line has been added at the end of the class for proper syntax formatting.

  • Improvement in Condition Checking in src/Macros/PestHttpRecorder.php
    The condition in the register method was restructured for better performance. A new condition was also added to assign a value to $queryName, which enhances the program’s functionality.

  • Enhanced Verification in src/Notion.php
    The process involved in the checkValidVersion method was optimized. This modification ensures that the validity of a version is checked more accurately now.

  • Code Streamlining in tests/RecordedEndpointPageTest.php
    The unused imports have been removed, contributing to a more concise and clean code. Also, the conditions in the should fetch specific property items of a page test were revised for improved performance and test results.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants