(Fix) Tx Table fails to display OutgoingTx data

[fernandomg]

This is @Agupane finding, we were working on fixes.

• wrong parameters order: c887c71
• wrong logic for some sendTokens: cdcdd07
• invalid display of txs amount with long decimals: 55eee73

[ghost]

Travis automatic deployment:
https://pr799--safereact.review.gnosisdev.com/app

[francovenica]

Outgoing tx looks fine

[ghost]

Travis automatic deployment:
https://pr799--safereact.review.gnosisdev.com/app

[francovenica]

@lukasschor Just to clarify. We should see the short notation (<0.0001) in both, the tx and the overview? or just in the tx row?
Also, it is not working for ETH
@Agupane @fernandomg

[lukasschor]

Do we show the exact number in the transaction details? If yes, then I think this should be fine.

So it should ideally show the exact number in the details. But this would not be a release blocker for me. Users can always go to etherscan, but then we should fix it later.

[lukasschor]

The fact that it does not shorten for ETH is also fine for now.

[francovenica]

@lukasschor incoming tx should also use the short notation? I think it should, for consistency

[lukasschor]

@fernandomg

If possible could you change the behavior to

• Short notation in the overview for all transactions (incoming, outgoing, ETH/ERC-20)

• Long notation in the transaction details for all transactions

If we can merge it by Monday we can of course include it in the release. But if there's not enough time to do testing, afterwards I would leave it out for the release. We can and just make a hotfix (2.0.1.) afterwards.