Skip to content
This repository has been archived by the owner on Nov 10, 2023. It is now read-only.

v1.9.4 #754

Merged
merged 13 commits into from
Apr 9, 2020
Merged

v1.9.4 #754

merged 13 commits into from
Apr 9, 2020

Commits on Apr 3, 2020

  1. Bug: Invalid V in signature with eth_sign (#728)

    * Fix invalid V with metamask/ledger
    
    * DONT FORGET TO REVERT BEFORE MERGING: test deployment
    
    * DONT FORGET TO REVERT BEFORE MERGING 2: test deployment
    
    * Revert "DONT FORGET TO REVERT BEFORE MERGING 2: test deployment"
    
    This reverts commit 8331f2a.
    
    * Revert "DONT FORGET TO REVERT BEFORE MERGING: test deployment"
    
    This reverts commit 03b81e3.
    mmv08 authored Apr 3, 2020
    Configuration menu
    Copy the full SHA
    94a56d2 View commit details
    Browse the repository at this point in the history
  2. BUG: Only injected providers are cached as last used provider (#733)

    * cache every used provider, not only injected one
    
    * package json update
    mmv08 authored Apr 3, 2020
    Configuration menu
    Copy the full SHA
    727b164 View commit details
    Browse the repository at this point in the history

Commits on Apr 6, 2020

  1. (Fix) Adapt app to back-end changes (#736)

    * refactor: Set success status to `201` (CREATED)
    
    * refactor: return `null` when there's no latestTx
    fernandomg authored Apr 6, 2020
    Configuration menu
    Copy the full SHA
    ba49c97 View commit details
    Browse the repository at this point in the history
  2. (Fix) Transaction not automatically executed (#716)

    * feature: action/reducer to UPDATE_SAFE_NONCE
    
    * refactor: when processing txs returned from backend, extract latest tx nonce value and store it in the safe's state
    
    * chore: update `yarn.lock`
    
    * refactor: `UPDATE_SAFE_THRESHOLD` and `UPDATE_SAFE_NONCE` discarded in favor of `UPDATE_SAFE`
    
    * refactor: use `SAFE_REDUCER_ID` constant
    
    * refactor: remove `updateSafeNonce` file
    fernandomg authored Apr 6, 2020
    Configuration menu
    Copy the full SHA
    0441ce2 View commit details
    Browse the repository at this point in the history

Commits on Apr 7, 2020

  1. (Fix) Change the order of the upgrade methods lookup (#740)

    * fix: change the order of the upgrade methods lookup
    
    The `isUpgradeTransaction` method was looking for the methods in an wrong order (#599).
    The proper order was set in #610, but `isUpgradeTransaction` wasn't updated.
    
    * fix: contract upgrade version lookup
    fernandomg authored Apr 7, 2020
    Configuration menu
    Copy the full SHA
    e33d9fd View commit details
    Browse the repository at this point in the history

Commits on Apr 8, 2020

  1. Feature: Use eth_sign for hardware wallets connected via onboard.js (#…

    …742)
    
    * Use eth_sign for hardware wallets
    
    * install onboard.js with fix from forked repo
    
    * rebuild yarn.lock to fix cached onboard
    
    * update bnc-onboard
    mmv08 authored Apr 8, 2020
    Configuration menu
    Copy the full SHA
    b8bfeab View commit details
    Browse the repository at this point in the history
  2. update package json (#743)

    mmv08 authored Apr 8, 2020
    Configuration menu
    Copy the full SHA
    fbc3696 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    fc68f70 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    d2f81fc View commit details
    Browse the repository at this point in the history

Commits on Apr 9, 2020

  1. (Fix) Properly decode threshold value in tx details (#749)

    * fix: Display new threshold value when changing its value
    
    There was a typo for the `changeThreshold` action
    
    fixes #746
    
    * refactor: use a constant for safe methods names
    fernandomg authored Apr 9, 2020
    Configuration menu
    Copy the full SHA
    1ac13c6 View commit details
    Browse the repository at this point in the history
  2. fix: check for decimals method in transferredTokens (#748)

    Previously we were looking for `decimals` hash in the contract `code`.
    There are some contracts like USDC who happen to be behind a FiatTokenProxy, making it upgradable.
    By directly calling the `decimals()` method, we interact with the contract and can be sure that the `decimals()` method is present.
    
    fixes #678
    fernandomg authored Apr 9, 2020
    Configuration menu
    Copy the full SHA
    b0849ee View commit details
    Browse the repository at this point in the history
  3. Bug #747: Don't use getLastTxNonce to fetch safe nonce (#750)

    * don't use getLastTxNonce to fetch safe nonce
    
    * fetch safe nonce in checkAndUpdateSafe
    
    * checkAndUpdateSafe refactor
    
    * remove nonce update logic from UPDATE_SAFE reducer
    
    * handle the case when localSafe returns undefined
    
    * handle the case when localSafe returns undefined in buildTransactionFrom
    
    * bump package json version to 1.9.4
    mmv08 authored Apr 9, 2020
    Configuration menu
    Copy the full SHA
    b1f50c7 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    4bfe937 View commit details
    Browse the repository at this point in the history