This repository has been archived by the owner on Nov 10, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 363
(Fix) Basic mobile responsiveness #532
Merged
gabitoesmiapodo
merged 19 commits into
development
from
fix/#279-basic-mobile-responsiveness
Feb 6, 2020
Merged
(Fix) Basic mobile responsiveness #532
gabitoesmiapodo
merged 19 commits into
development
from
fix/#279-basic-mobile-responsiveness
Feb 6, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabitoesmiapodo
requested review from
fernandomg,
francovenica,
mmv08 and
lukasschor
February 5, 2020 20:57
Travis automatic deployment: |
lukasschor
approved these changes
Feb 6, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
Travis automatic deployment: |
1 similar comment
Travis automatic deployment: |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #279
Not sure if I addressed every issue there is, but I fixed quite a few. There are still parts of the app I don't know they exist, so I may have missed something.
Tried to make things at least fit in a 375px wide screen, maybe even less. Most things should look OK now, but there are a few components that couldn't be adapted easily to something nicer.
Tables should be horizontally scrollable now, but tables' footers don't seem to adapt to the table's width. It looks like this is the intended behavior.
I think that at the bare minimum users should be able to use the app on mobile devices now.
Some screenshots: