-
Notifications
You must be signed in to change notification settings - Fork 363
fix: history polling next
/transactions remaining pending
#3992
Conversation
CLA Assistant Lite All Contributors have signed the CLA. |
ESLint Summary View Full Report
Report generated by eslint-plus-action |
Pull Request Test Coverage Report for Build 2542661777
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks OK, let's test it 👍
Ok, so the issue with tx getting stuck in pending is fixed, but there are issues with the filter now. If you search for something like "incomming" > "amount" It will show the tx that meet the criteria, but then it will load a page with what it seems no filtering criteria (basically just looking for the next page) Try in this safe: Filter by: |
I've found the issue and am looking into it now. |
What it solves
History pointers polling
next
How this PR fixes it
loadHistoryTransactions
has been split back toloadHistoryTransactions
andloadPagedHistoryTransactions
, the latter used for loadingnext
+pageUrl
s.How to test it