Fix: gas estimation in 1.1.1 Safes

[katspaugh]

What it solves

Resolves #3983

How this PR fixes it

Gas estimation in 1.1.1 Safes was broken in many ways since #3868 or possibly even before.

The variable safeTxGas was redefined after its first usage. I moved it up.

How to test it

• Open a 1/X Safe v.1.1.1
• Make a simple tx
• Check that the gas limit and total gas depend on the safeTxGas

NB: editing the safeTxGas in the Advanced form will not automatically update the gas limit. This hasn't changed from prod.

Before (gas limit 60k):

After (gas limit 100k):

[github-actions]

CLA Assistant Lite All Contributors have signed the CLA.

[github-actions]

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type	Occurrences	Fixable
Errors	0	0
Warnings	0	0
Ignored	0	N/A

• Result: ✅ success
• Annotations: 0 total

---

^{Report generated by eslint-plus-action}

[github-actions]

Deployment links

⚪ Mainnet     🟣 Polygon     🟠 Rinkeby

[iamacook]

Looks good to me and works as intended.

[coveralls]

Pull Request Test Coverage Report for Build 2530364032

• 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage remained the same at 36.804%

---

Totals
Change from base Build 2514942154:	0.0%
Covered Lines:	3893
Relevant Lines:	9605

---

💛 - Coveralls

[usame-algan]

👍

[francovenica]

It seems that the fix is only for safes 1.1.1 and 1.0,0 with a 1/1 policy, for tx that are created and executed right away. (or at least I tried rejections, creating and queuing tx first and then executing and tx in safes 2/x, and those look the same in Dev)

The gas limit is being bumped up for tx that are created/executed right away.

I've checked that safes 1.3.0 are unaffected by this change