Feature #189: Cookie banner

[Agupane]

Closes #189

Description

• Implements cookie banner
• Also, we were having problems with flow's warning and error, so we updated flow-types dependencys

Looks like this now:

[ghost]

Travis automatic deployment:
https://pr296--safereact.review.gnosisdev.com

Storybook book automatic deployment:
https://pr296--safereactstorybook.review.gnosisdev.com

[lukasschor]

Looks good.

1. Pressing on "Accept cookies" would be counted as a consent to "necessary" AND "analytics", even if "analytics" is not selected? Only closing the banner through the "x" would limit the consent to "necessary", right?
2. Could we have the checkmark for "necessary" locked in, as shown in the designs? So it's not actually clickable. Currently it's possible to de-select necessary and close the banner, which should not be possible.
3. I'll send you the link to the Cookie Policy as soon as possible (waiting for our DPO to approve it)

[Agupane]

Hi @lukasschor !

1. No, if the user did not selected analytics, only necessary would be counted as a consent. If you close it through "X", yes, it will count only necessary as consent, event if the analytics were selected.
2. Of course, will do it
3. Sounds good thanks!

[mmv08]

Also, we were having problems with flow's warning and error, so we updated flow-types dependencys

How did you do that? I thought it was not fixable 😄

[mmv08]

cookiesSelector is used only in 1 component CookieBanner. I think we don't really need to put the state in redux store in that case.

[Agupane]

Hi @mikheevm !.

For updating the flow dependencies we did this:

- Deleted flow-typed folder
- flow-typed install
- Updated / fixed flowconfig file
- Updated / fixed eslintignore file

Also, about the cookiesSelector, I think it's a good idea to have it on the store, because later on we will need it for this two issues too:

• Intercom #169
• Add Google Analytics Tracking #272

[mmv08]

• Add Google Analytics Tracking #272

Sorry, I don't understand why we'd need it. Could you explain please? I thought we'd just load GA/Intercom script inside the cookiebanner component and then we can check localstorage in index.js

[Agupane]

I prefer to not load those scripts inside the cookie banner to avoid mixing things, I would prefer to do it that separately. And do things like this PR. If you still don't like the idea I can change it

[gabitoesmiapodo]

@Agupane @lukasschor

The checkbox's disabled status should be fixed now.

[ghost]

Travis automatic deployment:
https://pr296--safereact.review.gnosisdev.com

Storybook book automatic deployment:
https://pr296--safereactstorybook.review.gnosisdev.com

[mmv08]

I prefer to not load those scripts inside the cookie banner to avoid mixing things, I would prefer to do it that separately. And do things like this PR. If you still don't like the idea I can change it

Why not? The entire point of redux is to put state there if we have to share it between few places in our application. In this case, state is consumed only in CookieBanner component.

[Agupane]

It's not, it's consumed also in the google analytics component and will be on the intercom component. Anyways, I'm going to remove that from the store

[ghost]

Travis automatic deployment:
https://pr296--safereact.review.gnosisdev.com

[ghost]

Travis automatic deployment:
https://pr296--safereact.review.gnosisdev.com

[mmv08]

Good job 😃

[lukasschor]

Yes, cookie renewal should be:
365 days for positive
7 days for negative

[ghost]

Travis automatic deployment:
https://pr296--safereact.review.gnosisdev.com

[mmv08]

Sorry, we forgot about one more requirement. So by law the user should be able to change his consent any time. Because of this, we should have a button inside the interface which would open the cookie banner again. Let's do it in the sidebar at the bottom where we have all the legal links with a label "Cookies"

[ghost]

Travis automatic deployment:
https://pr296--safereact.review.gnosisdev.com

[Agupane]

Done, please check it now @mikheevm

[ghost]

Travis automatic deployment:
https://pr296--safereact.review.gnosisdev.com

[lukasschor]

Works well. However, I think it would be better UX if clicking on "Cookies" would also close the sidebar.

[mmv08]

I think using redux is not really needed because it could be done with react's component state: Sidebar and CookiesBanner components are childs of the same component PageFrame, you could just pass a function from there, but I'm ok with it, not asking for a change.

[ghost]

Travis automatic deployment:
https://pr296--safereact.review.gnosisdev.com

[Agupane]

It does that now @lukasschor

Works well. However, I think it would be better UX if clicking on "Cookies" would also close the sidebar.

It does that now please check it :)

[ghost]

Travis automatic deployment:
https://pr296--safereact.review.gnosisdev.com