Skip to content
This repository has been archived by the owner on Nov 10, 2023. It is now read-only.

Feature #236: Edit owner name in read-only mode #260

Closed
wants to merge 3 commits into from
Closed

Feature #236: Edit owner name in read-only mode #260

wants to merge 3 commits into from

Conversation

Agupane
Copy link
Contributor

@Agupane Agupane commented Nov 13, 2019

Closes #236

Description

  • Before this PR, a non-owner user wasn't able to change the owner's name, this pr allows that.

Looks like this now:

  • Owner user:
    image

  • Non-owner user:
    image

@mmv08 mmv08 changed the base branch from master to development November 13, 2019 13:51
mmv08
mmv08 approved these changes Nov 13, 2019
View reviewed changes
Copy link
Member

@mmv08 mmv08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job :)

@davizalpe
Copy link
Contributor

@Agupane please, could you close this PR and create a new one from the original repository? Thank you :)

@Agupane
Copy link
Contributor Author

Agupane commented Nov 13, 2019

Closing this pr in favour of this

@davidalbela

@Agupane Agupane closed this Nov 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mmv08 mmv08 mmv08 approved these changes

@germartinez germartinez Awaiting requested review from germartinez

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Agupane @davizalpe @mmv08