Feature #74: Safe list sidebar #179

mmv08 · 2019-09-19T11:47:20Z

This PR:

Implements Safe List Sidebar #74
Disable react/state-in-constructor because of an update in airbnb config, we didn't define state in constructor previously and I don't see any reason to do that.
Run tests sequentially (--runInBand)
Remove SafeList route and Footer component
Unify addSafe actions. Previously we had a default exported action which would accept the raw data and create safe instance record, and also exported an action which would just take the safe record. Default one was used only during safe creation, so I changed the creation a little bit and made action which would take the safe record default
Update few tests to use waitForElement instead of sleep function

…an /

ghost · 2019-09-19T12:02:40Z

Travis automatic deployment:
https://pr179--safereact.review.gnosisdev.com

Storybook book automatic deployment:
https://pr179--safereactstorybook.review.gnosisdev.com

ghost · 2019-09-19T12:20:35Z

Travis automatic deployment:
https://pr179--safereact.review.gnosisdev.com

Storybook book automatic deployment:
https://pr179--safereactstorybook.review.gnosisdev.com

ghost · 2019-09-19T12:40:14Z

Travis automatic deployment:
https://pr179--safereact.review.gnosisdev.com

Storybook book automatic deployment:
https://pr179--safereactstorybook.review.gnosisdev.com

ghost · 2019-09-19T14:32:39Z

Travis automatic deployment:
https://pr179--safereact.review.gnosisdev.com

Storybook book automatic deployment:
https://pr179--safereactstorybook.review.gnosisdev.com

ghost · 2019-09-19T15:19:48Z

Travis automatic deployment:
https://pr179--safereact.review.gnosisdev.com

Storybook book automatic deployment:
https://pr179--safereactstorybook.review.gnosisdev.com

lukasschor · 2019-09-19T20:33:18Z

Really like this feature. And most happy-cases work great. 👍

Just two issues I have found so far:

Search bar disappears or is only displayed half when more than a dozen or so safes are loaded. Given only few will probably have that many safes loaded, but there the search bar would probably add the most value.

When searching and then closing the sidebar with an active search, the search results are persistent the next time the sidebar is opened, yet the search term is cleared. Either the sidebar should show all Safes again, or the search term should still be in the search bar. I would prefer the former but happy for other suggestions or whatever is easieir to implement.

Also minor UI thing, I would assume that the line between the header and sidebar would be the same thickness as the other lines.

ghost · 2019-09-20T12:10:46Z

Travis automatic deployment:
https://pr179--safereact.review.gnosisdev.com

Storybook book automatic deployment:
https://pr179--safereactstorybook.review.gnosisdev.com

ghost · 2019-09-20T14:11:24Z

Travis automatic deployment:
https://pr179--safereact.review.gnosisdev.com

Storybook book automatic deployment:
https://pr179--safereactstorybook.review.gnosisdev.com

ghost · 2019-09-20T14:15:17Z

Travis automatic deployment:
https://pr179--safereact.review.gnosisdev.com

Storybook book automatic deployment:
https://pr179--safereactstorybook.review.gnosisdev.com

…r after 300ms after closing so user doesn\'t see the changes

ghost · 2019-09-23T10:47:57Z

Travis automatic deployment:
https://pr179--safereact.review.gnosisdev.com

Storybook book automatic deployment:
https://pr179--safereactstorybook.review.gnosisdev.com

ghost · 2019-09-23T13:06:02Z

Travis automatic deployment:
https://pr179--safereact.review.gnosisdev.com

Storybook book automatic deployment:
https://pr179--safereactstorybook.review.gnosisdev.com

ghost · 2019-09-23T15:02:17Z

Travis automatic deployment:
https://pr179--safereact.review.gnosisdev.com

Storybook book automatic deployment:
https://pr179--safereactstorybook.review.gnosisdev.com

lukasschor

Looks good to me now. 👍

src/logic/safe/utils/safeStorage.js

src/routes/index.js

ghost · 2019-09-24T09:07:18Z

Travis automatic deployment:
https://pr179--safereact.review.gnosisdev.com

Storybook book automatic deployment:
https://pr179--safereactstorybook.review.gnosisdev.com

mmv08 added 22 commits September 12, 2019 17:25

Sidebar component wip

1140a6c

dep bump

6ea743d

Change zIndex for header row so it's displayed over the drawer

21ccc50

add sidebar styles

49ba6d3

make sidebar toggleable

ceb44ab

eslint fixes

226d7fc

Add types for sidebar context

b6b8311

Fix safe list colors

f22c044

display eth balance

b170259

Add search row

3fa4f5c

handle search in sidebar

64e5e55

Add safe button handler in sidebar

a2bb2c2

Default safe WIP

699f1f8

Add setDefaultSafe action

138f462

setDefaultSafe action

a699012

default badges

579e9dc

show 'make default' button on safe hover in safe list sidebar, dep bump

b3840b1

save default safe to storage

05059dd

load default safe on initial load wip

99fd7db

display loader on initial load when loadingg defaultSafe

c882c6f

Setting 1 safe as default WIP

b531ffd

Fix single default safe, fix redirect when initial route was other th…

35bc1c2

…an /

mmv08 added the WIP label Sep 19, 2019

mmv08 requested a review from lukasschor September 19, 2019 11:47

Pull from dev, conflict fixes

5a2d70b

Remove Footer

14b946a

remove SafeList route because the list moved to sidebar

db9788b

unify imports

232c741

fix send funds tests

dcdc965

Fix funds test, fix create safe test

e3b770b

mmv08 added 2 commits September 20, 2019 18:05

Fix tests (finally)

60e2bb0

Clear filter on sidebar close

3ce3bde

Dep bump, header border-bottom/shadow updates, clear filter in sideBa…

fbb89bb

…r after 300ms after closing so user doesn\'t see the changes

mmv08 added 3 commits September 23, 2019 15:26

Sort safes alphabetically in the sidebar

6d1c44b

scrollable safelist in sidebar

6e80d09

Add default label test for sidebar

0fd579f

Add default safe test

957c068

mmv08 removed the WIP label Sep 23, 2019

mmv08 requested a review from germartinez September 23, 2019 15:02

lukasschor approved these changes Sep 23, 2019

View reviewed changes

germartinez reviewed Sep 24, 2019

View reviewed changes

src/logic/safe/utils/safeStorage.js Outdated Show resolved Hide resolved

src/routes/index.js Outdated Show resolved Hide resolved

typo fixeS

16703e9

mmv08 requested a review from germartinez September 24, 2019 09:07

germartinez approved these changes Sep 24, 2019

View reviewed changes

mmv08 merged commit baae350 into development Sep 24, 2019

mmv08 deleted the 74-safe-list-sidebar branch September 24, 2019 09:43

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature #74: Safe list sidebar #179

Feature #74: Safe list sidebar #179

mmv08 commented Sep 19, 2019 •

edited

Loading

ghost commented Sep 19, 2019

ghost commented Sep 19, 2019

ghost commented Sep 19, 2019

ghost commented Sep 19, 2019

ghost commented Sep 19, 2019

lukasschor commented Sep 19, 2019

ghost commented Sep 20, 2019

ghost commented Sep 20, 2019

ghost commented Sep 20, 2019

ghost commented Sep 23, 2019

ghost commented Sep 23, 2019

ghost commented Sep 23, 2019

lukasschor left a comment

ghost commented Sep 24, 2019

Feature #74: Safe list sidebar #179

Feature #74: Safe list sidebar #179

Conversation

mmv08 commented Sep 19, 2019 • edited Loading

This PR:

ghost commented Sep 19, 2019

ghost commented Sep 19, 2019

ghost commented Sep 19, 2019

ghost commented Sep 19, 2019

ghost commented Sep 19, 2019

lukasschor commented Sep 19, 2019

ghost commented Sep 20, 2019

ghost commented Sep 20, 2019

ghost commented Sep 20, 2019

ghost commented Sep 23, 2019

ghost commented Sep 23, 2019

ghost commented Sep 23, 2019

lukasschor left a comment

Choose a reason for hiding this comment

ghost commented Sep 24, 2019

mmv08 commented Sep 19, 2019 •

edited

Loading