Skip to content
This repository has been archived by the owner on Nov 10, 2023. It is now read-only.

Add "QR Code scan button" #511

Closed
lukasschor opened this issue Feb 4, 2020 · 4 comments · Fixed by #873
Closed

Add "QR Code scan button" #511

lukasschor opened this issue Feb 4, 2020 · 4 comments · Fixed by #873
Assignees
@Agupane
Labels
Enhancement ✨ Minor Improvement / changes to existing functionality Major Needs to be fixed for immediate next public release.

Comments

@lukasschor
Copy link
Member

lukasschor commented Feb 4, 2020 •
edited
Loading

Add QR code scan feature to the follwing flows:

  • Add Owner
  • Replace Owner
  • Load Safe
  • Create new address book entry

Screenshot 2020-02-04 at 22.09.00.png
Screenshot 2020-02-04 at 22.08.52.png
image.png
@lukasschor lukasschor added Enhancement ✨ Minor Improvement / changes to existing functionality Major Needs to be fixed for immediate next public release. labels Feb 4, 2020
@lukasschor lukasschor changed the title Add "QR Code scan button" in Add owner flow Add "QR Code scan button" in Add/Replace owner flow Feb 4, 2020
@lukasschor lukasschor changed the title Add "QR Code scan button" in Add/Replace owner flow Add "QR Code scan button" Feb 6, 2020
@fernandomg
Copy link
Contributor

We should consider fixing the QR-reader across the whole app as part of this task (#400, #480).

@mmv08
Copy link
Member

mmv08 commented Feb 18, 2020

@fernandomg? Fixing it? Is it broken?

@fernandomg
Copy link
Contributor

@fernandomg? Fixing it? Is it broken?

@mikheevm, At least in #480 according to the description.
In #400, it needs to be added as well as in here.

@mmv08
Copy link
Member

mmv08 commented Feb 18, 2020

Most likely in #480 fieldMutator prop is missing

@lukasschor lukasschor mentioned this issue Apr 8, 2020
Closed
@mmv08 mmv08 mentioned this issue Apr 24, 2020
Merged
@Agupane Agupane self-assigned this May 4, 2020
@Agupane Agupane mentioned this issue May 5, 2020
Merged
Agupane added a commit that referenced this issue May 8, 2020
@Agupane
(Fix) #511 - QR scan button (#873)
4098a8b 
* Creates ScanQRWrapper to avoid duplicated logic
Refactors components that uses ScanQRWrapper

* Adds closeQrModal to props.handleScan callback

* Fixs mutators usage on components with qrScanWrapper

* Exports getNameFromAdbk
Fixs displaying address on send funds, also displays the name

* Fixs sendCustomTx qrCode
Fixs sendCollectible qrCode
Fixs loadAddress qrCode
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Agupane Agupane

Labels
Enhancement ✨ Minor Improvement / changes to existing functionality Major Needs to be fixed for immediate next public release.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

(Fix) #511 - QR scan button 5afe/safe-react
4 participants
@fernandomg @mmv08 @lukasschor @Agupane