Can't execute transaction that has more confirmations than required.

[tschubotz]

• Create Safe with 5 owners and threshold 2
• Create tx with owner 1
• Confirm tx with owner 2 and 3 but DON'T execute right away.
• Now try to execute tx with owner 1
• It'll not work.

Example Safe with that issue: latest tx on https://rinkeby.gnosis-safe.io/safes/0xca57093Df2ff3170Ddf2f223DED93a0Ddcc4426c/transactions

Let me know if you need more details.

[rmeissner]

https://github.com/gnosis/safe-react/blob/fff057d8e6f387acac12b7eb9653b460ab853a34/src/routes/safe/components/Transactions/TxsTable/ExpandedTx/ApproveTxModal/index.jsx#L72 This should probably not check equals but >=

[fernandomg]

The transaction to execute the tx has gone through ok: https://rinkeby.etherscan.io/tx/0xa59c6c04a2bbf288c1338cc0ffef888a94bea6be7ed0ce9479a5d02811a0fcef (called the approveHash method)

The transaction detail the endpoint is returning is incomplete (see nulls in blockNumber, transactionHash, executionDate, executor):

  {
    "safe": "0xca57093Df2ff3170Ddf2f223DED93a0Ddcc4426c",
    "to": "0xca57093Df2ff3170Ddf2f223DED93a0Ddcc4426c",
    "value": "100000000000000000",
    "data": null,
    "operation": 0,
    "gasToken": "0x0000000000000000000000000000000000000000",
    "safeTxGas": 0,
    "baseGas": 0,
    "gasPrice": "0",
    "refundReceiver": "0x0000000000000000000000000000000000000000",
    "nonce": 1,
    "safeTxHash": "0x6a91e72315bf2b15fb66ba233be0e34950a91d9a161f1247454116418524f9af",
    "blockNumber": null,
    "transactionHash": null,
    "submissionDate": "2020-01-07T17:09:37.040111Z",
    "isExecuted": false,
    "executionDate": null,
    "executor": null,
    "confirmations": [
      {
        "owner": "0x39cBD3814757Be997040E51921e8D54618278A08",
        "submissionDate": "2020-01-07T17:09:48.890360Z",
        "transactionHash": "0x5af9eb727899caa20ea1dedabdc34208d003bf1a69357f62828802755c0e9c78",
        "confirmationType": "CONFIRMATION",
        "signature": null
      },
      {
        "owner": "0x00984CBdcAc32676d811f5bDB82bC50ae6dd6784",
        "submissionDate": "2020-01-07T17:10:15.380492Z",
        "transactionHash": "0x72c4fa9c8b689c7d1ae4cee5da72a7191aaf19d270c9d400b0f383b6559b0c81",
        "confirmationType": "CONFIRMATION",
        "signature": null
      },
      {
        "owner": "0x0e329fa8d6Fcd1ba0Cda495431F1f7CA24F442C2",
        "submissionDate": "2020-01-07T17:10:54.681146Z",
        "transactionHash": "0x0c7bf51ab66d70d0aa646efee7c3dfa57a17f1b36613f690995a85343f5b3a04",
        "confirmationType": "CONFIRMATION",
        "signature": null
      }
    ],
    "signatures": null
  }

the endpoint: https://safe-transaction.rinkeby.gnosis.io/api/v1/safes/0xca57093Df2ff3170Ddf2f223DED93a0Ddcc4426c/transactions/

[fernandomg]

https://github.com/gnosis/safe-react/blob/fff057d8e6f387acac12b7eb9653b460ab853a34/src/routes/safe/components/Transactions/TxsTable/ExpandedTx/ApproveTxModal/index.jsx#L72

This should probably not check equals but >=

I didn't see your message, sorry. This makes complete sense

[francovenica]

Another way to reproduce the issue, so we can test when gets solved:

1 - Have a Safe with a "3 out of 4" rule
2 - Modify the rule to make it "1 out of 4"
3 - Sign it with the 3 owners but do not execute it
4 - Create a new transaction, like a token transfer
5 - Same as before, sign it with every one. You should not be able to execute this one since the change of "Required confirmation transaction" is still pending to be excecuted
6 - Execute the "Required Confirmation transaction", now the safe requires only 1 owner to do transactions
7 - The last transaction, the one for the transfer of funds should be locked now. if a person tries to execute it it will just "approve it"