Skip to content
This repository has been archived by the owner on Nov 10, 2023. It is now read-only.

Notifications shown after loading Safe #381

Closed
1 of 6 tasks
lukasschor opened this issue Dec 18, 2019 · 0 comments
Closed
1 of 6 tasks

Notifications shown after loading Safe #381

lukasschor opened this issue Dec 18, 2019 · 0 comments
Assignees
@fernandomg
Labels
Bug 🐛 Something isn't working Major Needs to be fixed for immediate next public release.
Milestone
Sprint 1 "Fitz Roy"

Comments

@lukasschor
Copy link
Member

lukasschor commented Dec 18, 2019 •
edited
Loading

Obtained Result:

After loading a Safe, multiple incoming transaction notifications are displayed.

Expected result:

Don't show any notifications after loading a Safe (or indirectly loading it through a link) as specified here: #333 (comment)

Environment

  • Browser: Chrome
  • Safe: 0xfF501B324DC6d78dC9F983f140B9211c3EdB4dc7
  • Wallet: Metamask
  • App Version:
  • Environment:
    • dev (rinkeby)
    • staging (rinkeby)
    • production (mainnet)
    • PR #
      • PR Network:
        • mainnet
        • rinkeby

Steps to reproduce

Open this link in incognito: https://safe-team-mainnet.staging.gnosisdev.com/safes/0xfF501B324DC6d78dC9F983f140B9211c3EdB4dc7/transactions

Screenshots

Screenshot 2019-12-18 at 13 41 00
@lukasschor lukasschor added Bug 🐛 Something isn't working Minor Needs to be fixed within the next 1-3 public releases. Major Needs to be fixed for immediate next public release. and removed Minor Needs to be fixed within the next 1-3 public releases. labels Dec 18, 2019
@fernandomg fernandomg mentioned this issue Dec 26, 2019
Merged
@lukasschor lukasschor added this to the Sprint 1 "Fitz Roy" milestone Jan 8, 2020
germartinez pushed a commit that referenced this issue Jan 16, 2020
@fernandomg @germartinez
Fix #381: notification shown after loading safe (#402)
f64ebf9 
* Prevent notifications from showing after loading safe

* Make a safe-based sessionStorage control

* Show notifications for new Safes and prevent displaying oldest incoming tx for newly loaded Safe

* Create `currentSession` state

* Add `currentSession` to the Store

* Initialize `currentSession`

* Use `currentSession` to handle notifications for incoming Transactions

* Remove `updateUserStatus`

* Move the load of the current session from storage to app startup

* Fix duplicated reducer id

* Adapt notificationsMiddleware
germartinez pushed a commit that referenced this issue Jan 16, 2020
@fernandomg @germartinez
Fix #381: notification shown after loading safe (#402)
6c036e2 
* Prevent notifications from showing after loading safe

* Make a safe-based sessionStorage control

* Show notifications for new Safes and prevent displaying oldest incoming tx for newly loaded Safe

* Create `currentSession` state

* Add `currentSession` to the Store

* Initialize `currentSession`

* Use `currentSession` to handle notifications for incoming Transactions

* Remove `updateUserStatus`

* Move the load of the current session from storage to app startup

* Fix duplicated reducer id

* Adapt notificationsMiddleware
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@fernandomg fernandomg

Labels
Bug 🐛 Something isn't working Major Needs to be fixed for immediate next public release.
Projects
None yet
Milestone
Sprint 1 "Fitz Roy"
Development

No branches or pull requests
2 participants
@fernandomg @lukasschor